Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce tiled layout in the timeline #1119

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Introduce tiled layout in the timeline #1119

merged 1 commit into from
Aug 4, 2022

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jun 15, 2022 •
edited
Loading

✔️ Done and ready for reviews ✔️

Done

  • Finish AppNavigation rework
  • First draft of tiled algo
  • Thumbnails for videos
  • Allow selection
    • Improve :hover style for Checkbox without label
    • Allow setting a background to Checkbox
    • Checkbox rendering on slim photos
    • Download
    • Favorite
    • Delete (3 actions in the 3 dot menu)
    • Added focused state
    • Select on keyuo.enter when focused
  • Improve reload on bottom reached
  • Split into section by month
  • Check that it is pixel perfect
    • Remove slight border radius on picture
    • Check that the default height is fine
  • Add Header
    • Fix respect of force-title attribute in Actions
  • Clean TiledLayout code
    • Extract algo into JS
    • Write tests
    • Check with very tall pictures
    • Check with very large pictures
    • Support resize
      • Detect navigation bar toggle
    • Do not flash loading indicator when fast scrolling
  • Implement virtual scrolling
    • Support different container (window, custom element, and inner element)
  • What about files that do not have metadata? => default to 256*256
  • Next and previous in Viewer don't match image order
  • Prioritize loading of visible pictures
  • Accessibility work
  • Check scroll on mobile
  • Use ul/li for item rendering

Example (28/07 - 10:30)

Screenshot 2022-07-28 at 10-31-59 Photos - Nextcloud

@artonge artonge added the 1. to develop Accepted and waiting to be taken care of label Jun 15, 2022
@artonge artonge added this to the Nextcloud 25 milestone Jun 15, 2022
@artonge artonge self-assigned this Jun 15, 2022
@artonge artonge added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jun 15, 2022
@artonge artonge force-pushed the feat/tiled_layout branch 2 times, most recently from 06d4add to 9abc22c Compare June 16, 2022 12:57
@jancborchardt
Copy link
Member

Nice! :)
The only weird part is in January 2021 with the 2 huge pictures – but I understand why it is like that with the panorama following them.

Also, the month/date titles can use a bit more padding to the top of them. :)

@artonge artonge force-pushed the feat/tiled_layout branch 2 times, most recently from 361f861 to 1bde0ab Compare June 22, 2022 17:20
@artonge artonge force-pushed the feat/tiled_layout branch from 1bde0ab to 9cbd071 Compare June 23, 2022 08:07
@artonge artonge added the enhancement New feature or request label Jun 29, 2022
@artonge artonge force-pushed the feat/tiled_layout branch from 9cbd071 to 288e97c Compare June 29, 2022 17:26
@artonge artonge force-pushed the feat/tiled_layout branch 2 times, most recently from 351eeec to cdac460 Compare July 9, 2022 08:47
@artonge artonge changed the base branch from master to photos2 July 9, 2022 08:48
@artonge
Copy link
Collaborator Author

artonge commented Jul 9, 2022

Changed target branch to photos2 so we can do the remaining work there.

@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 9, 2022
@artonge artonge requested review from a team, PVince81, skjnldsv and Pytal and removed request for a team July 9, 2022 08:49
Pytal
Pytal reviewed Jul 12, 2022
View reviewed changes
@artonge artonge force-pushed the feat/tiled_layout branch 3 times, most recently from 322c7c6 to 4492a82 Compare July 26, 2022 09:13
@artonge artonge changed the title Introduce tilted layout in the timeline Introduce tiled layout in the timeline Jul 27, 2022
@artonge artonge force-pushed the feat/tiled_layout branch from b13499f to 9c9b9c7 Compare July 27, 2022 10:06
@artonge artonge requested a review from Pytal July 27, 2022 10:07
Pytal
Pytal approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than comments and eslint errors

jancborchardt
jancborchardt reviewed Jul 27, 2022
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment •
edited by artonge
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks suuper nice @artonge, only 2 details:

  • The date divider seems to not left align with the images, but is a bit further to the left?
  • The date divider can use some more whitespace to the top (make it double :)

@artonge artonge force-pushed the feat/tiled_layout branch from 9c9b9c7 to 2da6c40 Compare July 28, 2022 08:30
@artonge artonge requested review from Pytal and jancborchardt July 28, 2022 15:32
@artonge artonge force-pushed the feat/tiled_layout branch from 2da6c40 to 4dd6e4e Compare July 28, 2022 15:34
artonge
artonge commented Aug 3, 2022
View reviewed changes
@artonge artonge force-pushed the feat/tiled_layout branch from 4dd6e4e to 598b484 Compare August 3, 2022 16:59
@skjnldsv
Copy link
Member

skjnldsv commented Aug 4, 2022

LGTM ? 🚀

CarlSchwan
CarlSchwan reviewed Aug 4, 2022
View reviewed changes
@artonge artonge force-pushed the feat/tiled_layout branch 2 times, most recently from 8866548 to 47a7164 Compare August 4, 2022 12:53
@artonge
Introduce tiled layout in the timeline
223172b 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the feat/tiled_layout branch from 47a7164 to 223172b Compare August 4, 2022 14:19
@artonge artonge merged commit 45dd621 into photos2 Aug 4, 2022
@artonge artonge deleted the feat/tiled_layout branch August 4, 2022 15:08
@skjnldsv
Copy link
Member

skjnldsv commented Aug 4, 2022

🎉🎉🎉🎉🎉🎉

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 4, 2022
@marcelklehr marcelklehr mentioned this pull request Aug 8, 2022
Closed
@joshtrichards joshtrichards added the feature: timeline Related to the timeline section label Oct 7, 2023
@joshtrichards joshtrichards mentioned this pull request Mar 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan CarlSchwan left review comments

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@artonge artonge

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request feature: timeline Related to the timeline section
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
6 participants
@artonge @jancborchardt @skjnldsv @CarlSchwan @Pytal @joshtrichards