-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce tiled layout in the timeline #1119
Conversation
06d4add
to
9abc22c
Compare
Nice! :) Also, the month/date titles can use a bit more padding to the top of them. :) |
361f861
to
1bde0ab
Compare
1bde0ab
to
9cbd071
Compare
9cbd071
to
288e97c
Compare
351eeec
to
cdac460
Compare
Changed target branch to |
322c7c6
to
4492a82
Compare
b13499f
to
9c9b9c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than comments and eslint errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks suuper nice @artonge, only 2 details:
- The date divider seems to not left align with the images, but is a bit further to the left?
- The date divider can use some more whitespace to the top (make it double :)
9c9b9c7
to
2da6c40
Compare
2da6c40
to
4dd6e4e
Compare
4dd6e4e
to
598b484
Compare
LGTM ? 🚀 |
8866548
to
47a7164
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
47a7164
to
223172b
Compare
🎉🎉🎉🎉🎉🎉 |
✔️ Done and ready for reviews ✔️
Done
:hover
style for Checkbox without labelforce-title
attribute inActions
TiledLayout
codeul/li
for item renderingExample (28/07 - 10:30)