Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Albums view #1142

Merged
merged 12 commits into from
Aug 23, 2022
Merged

Add Albums view #1142

merged 12 commits into from
Aug 23, 2022

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jul 27, 2022 •
edited
Loading

✔️ Done and ready for reviews ✔️

Side quests

  • Long press on mobile ?
  • Use exif data to sort files
  • Bug in DAV:SEARCH sorted by creationdate (some files from page 2 are before some files of page 1)
  • Issue with nc-vue::Action when parent is sticky

Screenshots

Empty album list Album list with content
Screenshot 2022-08-11 at 12-05-14 Photos - Nextcloud Screenshot from 2022-08-11 12-04-25
Album form modal Album form with a name filled Album form loading
Screenshot from 2022-08-11 12-05-36 Screenshot from 2022-08-11 12-05-56 Screenshot from 2022-08-11 12-06-12
Empty album content Album content with content Renaming an album
Screenshot 2022-08-11 at 11-44-05 Photos - Nextcloud Screenshot 2022-08-11 at 11-38-16 Photos - Nextcloud Screenshot 2022-08-11 at 11-39-11 Photos - Nextcloud
File picker preloading File picker with content File picker loading
Screenshot from 2022-08-11 11-47-41 Screenshot 2022-08-11 at 11-39-38 Photos - Nextcloud Screenshot 2022-08-11 at 12-13-56 Photos - Nextcloud
Album picker Album picker preloading
Screenshot 2022-08-11 at 12-16-52 Photos - Nextcloud Screenshot from 2022-08-11 11-47-21

@artonge artonge added enhancement New feature or request javascript Javascript related ticket 2. developing Work in progress feature: albums Related to the albums section labels Jul 27, 2022
@artonge artonge added this to the Nextcloud 25 milestone Jul 27, 2022
@artonge artonge self-assigned this Jul 27, 2022
@artonge artonge force-pushed the feat/album_frontend branch from b18ea6a to 545f255 Compare July 27, 2022 16:36
@artonge artonge changed the title Add "Albums" view Add Albums view Jul 28, 2022
@artonge artonge force-pushed the feat/album_frontend branch 8 times, most recently from a2d299a to b540a29 Compare August 4, 2022 15:20
@marcelklehr marcelklehr mentioned this pull request Aug 8, 2022
Closed
@artonge artonge force-pushed the feat/album_frontend branch 2 times, most recently from de38121 to 3139279 Compare August 8, 2022 20:37
@artonge artonge force-pushed the feat/album_frontend branch from 6b1feda to 7fe77c8 Compare August 8, 2022 22:03
@artonge
Copy link
Collaborator Author

artonge commented Aug 10, 2022 •
edited
Loading

Jan's notes

@jancborchardt See unchecked items for questions or validation :)

  • Add button has a bit too much space between + and "Add" text
    --> It is the default for Action buttons. Should be fixed in nc-vue.
  • Space below "Add" button is a bit too much in "All media" (it’s fine in the Albums view)
    --> Change margin-top 60px to 0px
  • Favorite icon is not so visible, possibly give it a white outline
    --> Added, but I think it looks weird:
    Screenshot from 2022-08-10 14-40-57
  • Multiselect and albums menu:
    • Download icon in multiselect menu is outlined, should be standard filled style
    • "Delete files from album" should be "Remove items from album"? With an X icon
    • Delete icon is not standard Material Design delete icon

Album view

  • Because of large padding of
    --> ??
  • Album date: Range of the date of the pictures in the album, e.g. "January–February 2022"
  • Album picture picker: Center loading spinner → Even better: Use skeleton screens with shimmer
    --> Is this solution ok with you?
    Screenshot from 2022-08-10 15-55-53
  • "Add photos" button to confirm should be on bottom right of dialog
  • Button wording should include album name: "Add photos to Sailing vacation"

@axellebot
Copy link

Favorite icon is not so visible, possibly give it a white outline **--> Added, but I think it looks weird:

Suggestion :

  • when Selecting/Hovering the image : adding a transparent black layer between thumbnail and fav icon
  • and otherwise do not display fav icon

@artonge artonge mentioned this pull request Aug 10, 2022
Closed
@artonge artonge requested review from skjnldsv, Pytal and icewind1991 and removed request for skjnldsv August 10, 2022 14:48
@artonge artonge removed the 2. developing Work in progress label Aug 10, 2022
artonge
artonge commented Aug 11, 2022
View reviewed changes
composer.json Show resolved Hide resolved
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
Merged
artonge
artonge commented Aug 17, 2022
View reviewed changes
src/Photos.vue Show resolved Hide resolved
artonge
artonge commented Aug 17, 2022
View reviewed changes
src/views/AlbumContent.vue Outdated Show resolved Hide resolved
artonge
artonge commented Aug 17, 2022
View reviewed changes
src/views/AlbumContent.vue Outdated Show resolved Hide resolved
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
Merged
@artonge artonge force-pushed the feat/album_frontend branch 3 times, most recently from 24793ec to 7934385 Compare August 22, 2022 17:44
icewind1991 and others added 12 commits August 22, 2022 20:03
@icewind1991 @artonge
add album database management bits
10f44aa 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@icewind1991 @artonge
retreive more metadata for album files
4aa8a0a 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@icewind1991 @artonge
dav api
3cd7fed 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@icewind1991 @artonge
use unique filenames in albums
62dbf99 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@icewind1991 @artonge
fix copyright headers
9c68a0f 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@icewind1991 @artonge
better error for duplicate
3b62ffb 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@icewind1991 @artonge
cast to int
6bb2c7a 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@icewind1991 @artonge
expose more metadata
fe215a8 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@icewind1991 @artonge
store album location and last added photo
f4dea80 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@icewind1991 @artonge
expose location and last-photo in dav
ef3780d 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@dependabot @artonge
Bump @nextcloud/axios from 1.9.0 to 1.10.0
0f2bcda 
Bumps [@nextcloud/axios](https://github.com/nextcloud/nextcloud-axios) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/nextcloud/nextcloud-axios/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-axios/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-axios@v1.9.0...v1.10.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/axios"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add Albums view
c8bf3a5 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the feat/album_frontend branch from 7934385 to c8bf3a5 Compare August 22, 2022 18:07
@artonge artonge merged commit 21d08d4 into photos2 Aug 23, 2022
@artonge artonge deleted the feat/album_frontend branch August 23, 2022 11:05
@nicorikken
Copy link

Thanks a lot for this work! 👏 Photos are my main use-case for Nextcloud, improvements like these are very welcome ❤️

@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
@stephanhoennekes stephanhoennekes mentioned this pull request Sep 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@marcelklehr marcelklehr marcelklehr left review comments

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews enhancement New feature or request feature: albums Related to the albums section javascript Javascript related ticket
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
7 participants
@artonge @axellebot @nicorikken @marcelklehr @CarlSchwan @Pytal @icewind1991