-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collaborators management views #1161
Conversation
a032535
to
166d387
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few things:
- The "Share link" finction looks oddly placed and not interactive. Maybe better as a secondary button on the bottom left instead?
- The gab below the input field looks off. Wouldn't this work like in Files, where people are picked one by one from the suggestion dropdown?
- Possibly a general Vue component thing, but there should be a close x within the modal on the top right
- Wording in the title subline: "users" to "people", and " group" needs to be plural "groups"
d0f6efb
to
bcf36f1
Compare
Looks very nice! Agree with everything mentioned, plus a few more points:
cc @jancborchardt as well |
0a1f2c5
to
7d3b378
Compare
ad6126a
to
13ad35c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
48d9e0e
to
f24e28b
Compare
b1b4090
to
5fcd3f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed together, looks good 👍
the only critical part I think is the DB schema to remove the cached display name and use the display name cache instead / lazy user
for retrieving display names, use |
/compile amend / |
Signed-off-by: Louis Chemineau <louis@chmn.me> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
5fcd3f9
to
35af106
Compare
Also contains some minor css tweaks.
Screenshots
Fix #1226