Bump webdav to ^4 #1184
Merged
Bump webdav to ^4 #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
a team,
PVince81,
artonge and
Pytal
and removed request for
a team
|
Does the client API stay the same? That's nice! |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Yes and no, I had to adapt a few hacks we do as well as their new esm export. |
marcelklehr
reviewed
Aug 26, 2022
| @@ -41,9 +42,10 @@ webpackConfig.module.rules = Object.values(webpackRules) | |||
| webpackConfig.plugins.push( | |||
| // patch webdav/dist/request.js | |||
| new webpack.NormalModuleReplacementPlugin( | |||
| /request.js/, | |||
| /request(\.js)?/, | |||
There was a problem hiding this comment.
oof, I didn't know about this. :'D
There was a problem hiding this comment.
We could make it upstream, but perry-mitchell/webdav-client#179
marcelklehr
approved these changes
Aug 26, 2022
marcelklehr
reviewed
Sep 1, 2022
| function(resource) { | ||
| if (resource.context.indexOf('webdav/dist') > -1) { | ||
| if (resource.context.indexOf('webdav') > -1) { | ||
| console.debug('Patched request for webdav', basename(resource.contextInfo.issuer)) |
There was a problem hiding this comment.
This doesn't seem to work on latest master, though :S I've put a direct throw Error into patchedRequest and it never gets thrown?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused service since 3 years...
https://github.com/nextcloud/photos/pull/4/files#diff-239342c3890dc7339f0c87a00179a78c0502d3f74b5b387f18fd2e00cb19d194L57
Webdav 3 is deprecated and don't receive updates anymore