Implement default Photos folder

[skjnldsv]

• Move settings to proper Modal
• Added default Photos location
  Default set to /Photos

  photos/lib/Service/UserConfigService.php

  Line 37 in a07c06f

  'photosLocation' => '/Photos',

• Implement UserConfig service
• Cleanup code

[skjnldsv]

Could theoritecally be exposed as a capability and used straight away by the

photos/src/mixins/UserConfig.js

Lines 34 to 39 in 34948e3

	return {
	croppedLayout: croppedLayoutLocalStorage !== null
	? croppedLayoutLocalStorage === 'true'
	: loadState('photos', 'croppedLayout') === 'true',
	photosLocation: loadState('photos', 'photosLocation'),
	}

instead of having to declare them again in the front :)

[artonge]

Or:

Suggested change

	updatePhotosFolder(path) {
	console.debug(`Path '${path}' selected for photos location`)
	if (typeof path !== 'string' || path.trim() === '' || !path.startsWith('/')) {
	showError(t('photos', 'Invalid location selected'))
	return
	}
	if (path.includes('//')) {
	path = path.replace(/\/\//gi, '/')
	}
	this.photosLocation = path
	this.updateSetting('photosLocation')
	},
	updatePhotosFolder: debounce(function (path) {
	console.debug(`Path '${path}' selected for photos location`)
	if (typeof path !== 'string' || path.trim() === '' || !path.startsWith('/')) {
	showError(t('photos', 'Invalid location selected'))
	return
	}
	if (path.includes('//')) {
	path = path.replace(/\/\//gi, '/')
	}
	this.photosLocation = path
	this.updateSetting('photosLocation')
	}),

But works as you coded it so feel free to ignore.

[skjnldsv]

debounce requires a function reference, here the function will be created on each call, so it will be different and not debounced properly, no?

[skjnldsv]

Also, sometimes you don't need to debounce, like right after picking with the Folder picker for example

[artonge]

debounce requires a function reference, here the function will be created on each call, so it will be different and not debounced properly, no?

Here, debounce will be called only once at component creation and return a debounced function from the passed one. So the function will stay the same

[artonge]

Is this not working?

Suggested change

	debounceUpdatePhotosFolder: debounce(function(...args) {
	this.updatePhotosFolder(...args)
	}, 300),
	debounceUpdatePhotosFolder: debounce(this.updatePhotosFolder, 300),

[skjnldsv]

let me check :)

[skjnldsv]

No, because this is not set there otherwise