Fix file picker initialization #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
a team,
PVince81 and
szaimen
and removed request for
a team
|
/compile amend / |
|
master is 26, please trigger backport if necessary. |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/picker
branch
from
db283f8 to
221b2c8
Compare
|
/backport to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
Thanks ! :) |
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1297
Seems like until we can properly reject the picker on close or ESC, we cannot really prevent a loop init.
The picker really needs to be re-written in vue. Until then, this should mitigate the problem