Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sortFilesByTimestamp #1330

Closed
wants to merge 2 commits into from
Closed

Conversation

valdearg
Copy link
Contributor

Might fix sorting.

Signed-off-by: valdearg valdearg@users.noreply.github.com

Signed-off-by: valdearg <valdearg@users.noreply.github.com>
Copy link

@AndyXheli AndyXheli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested looks good with me

@artonge
Copy link
Collaborator

artonge commented Oct 11, 2022

@valdearg would you be able to lint, compile and commit the build files ?

npm ci
npm run lint:fix
npm run build
git add .
git commit --amend
git push --force

@szaimen szaimen added this to the Nextcloud 26 milestone Oct 11, 2022
@szaimen szaimen added the 3. to review Waiting for reviews label Oct 11, 2022
@artonge
Copy link
Collaborator

artonge commented Oct 11, 2022

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 11, 2022
@valdearg
Copy link
Contributor Author

Haven't the foggiest idea what I've done now, but feel free to try the changes?

@AndyXheli
Copy link

I think something is wrong :(

@valdearg
Copy link
Contributor Author

I think something is wrong :(

#1332 sorry, think it might be better to just try that new branch, apologies for this mess.

@AndyXheli
Copy link

@valdearg I think you might need to create a new pr! If you want I can take care of it in a few hours! Whatever you like 🙂

@AndyXheli
Copy link

No worries make sure to close this

@valdearg valdearg closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants