Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] update vue to 7.3.0 #1572

Closed
wants to merge 1 commit into from
Closed

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jan 3, 2023

Signed-off-by: Simon L szaimen@e.mail.de

@szaimen szaimen added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Jan 3, 2023
@szaimen szaimen added this to the Nextcloud 25.0.3 milestone Jan 3, 2023
@szaimen szaimen requested review from artonge, a team, skjnldsv and Pytal and removed request for a team January 3, 2023 15:25
@szaimen
Copy link
Contributor Author

szaimen commented Jan 3, 2023

/compile amend /

Signed-off-by: Simon L <szaimen@e.mail.de>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/noid/update-vue-to-7.3.0 branch from 7ab1b41 to 1f5fdae Compare January 3, 2023 15:56
@szaimen szaimen requested a review from PVince81 January 4, 2023 09:31
@artonge
Copy link
Collaborator

artonge commented Jan 4, 2023

Are cypress tests also failing on master ?

@szaimen
Copy link
Contributor Author

szaimen commented Jan 4, 2023

I dont think so: #1556

@szaimen
Copy link
Contributor Author

szaimen commented Jan 4, 2023

Not sure if this error is really cause by the vue dump?
image

@artonge
Copy link
Collaborator

artonge commented Jan 4, 2023

Can you double check if adding a collaborator to an album works ? Looks like clicking on "Save" does not work for cypress

@szaimen
Copy link
Contributor Author

szaimen commented Jan 4, 2023

Can you double check if adding a collaborator to an album works ? Looks like clicking on "Save" does not work for cypress

Sorry, working on something else currently. Will not get to this until tomorrow evening probably.

@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
5 tasks
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 6, 2023
@blizzz
Copy link
Member

blizzz commented Feb 7, 2023

conflicts

@szaimen szaimen closed this Feb 7, 2023
@szaimen szaimen deleted the enh/noid/update-vue-to-7.3.0 branch February 7, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants