Move heading to the main content #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Pytal
approved these changes
Apr 6, 2023
JuliaKirschenheuter
force-pushed
the
fix/37174-palce_headinginside_of_the_main_content
branch
from
758ee83
to
f155d4e
Compare
artonge
approved these changes
Apr 6, 2023
|
/rebase |
|
Rebasing to have green CI |
nextcloud-command
force-pushed
the
fix/37174-palce_headinginside_of_the_main_content
branch
from
f155d4e
to
04c4ea7
Compare
JuliaKirschenheuter
force-pushed
the
fix/37174-palce_headinginside_of_the_main_content
branch
from
04c4ea7
to
18bd159
Compare
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
JuliaKirschenheuter
force-pushed
the
fix/37174-palce_headinginside_of_the_main_content
branch
from
18bd159
to
c74da05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move
<h1>heading in the main landmark instead of the<header>.By jumping directly to the h1 heading the user would be able to navigate through the main content of the page immediately.
See nextcloud/server#36911 (comment)