Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix back arrow position in wide screens #2324

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fix back arrow position in wide screens #2324

merged 2 commits into from
Feb 7, 2024

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Feb 7, 2024 •
edited
Loading

Fix #2321

Before

Screen size Back button Menu button
Wide Screenshot from 2024-02-07 15-39-49 Screenshot from 2024-02-07 15-40-00
Narrow Screenshot from 2024-02-07 15-39-51 Screenshot from 2024-02-07 15-39-55

After

Screen size Back button Menu button
Wide Screenshot from 2024-02-07 15-34-43 Screenshot from 2024-02-07 15-34-52
Narrow Screenshot from 2024-02-07 15-34-47 Screenshot from 2024-02-07 15-34-50

@artonge
Fix back arrow position in wide screens
52cbd43 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Compile assets
92eb933 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge self-assigned this Feb 7, 2024
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Feb 7, 2024
@artonge artonge added this to the Nextcloud 29 milestone Feb 7, 2024
@JuliaKirschenheuter
Copy link
Contributor

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Feb 7, 2024
@artonge artonge merged commit e5ae1ac into master Feb 7, 2024
23 checks passed
@artonge artonge deleted the artonge/fix/back_arrow branch February 7, 2024 17:05
@backportbot backportbot bot mentioned this pull request Feb 7, 2024
Merged
2 tasks
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Feb 7, 2024
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@emoral435 emoral435 emoral435 approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@szaimen szaimen Awaiting requested review from szaimen

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Back button not visible when sidebar open
4 participants
@artonge @JuliaKirschenheuter @susnux @emoral435