feat(preview): Improve preview management #3370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
artonge
commented
Jan 16, 2026
artonge
commented
- Properly access blurhash value
- Do not request small preview if blurhash exists
- Be more honest about the actual preview size. The server only servers sizes that are multiple of 4, so 64, 256, 1024, 4096.
- Use smaller previews on mobile.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
artonge
force-pushed
the
artonge/feat/better_preview_management
branch
from
7941daa to
5558ecd
Compare
artonge
added
3. to review
Collaborator
Author
|
/backport to stable32 |
Collaborator
Author
|
/backport to stable31 |
Collaborator
Author
|
/backport to stable30 |
CarlSchwan
approved these changes
Jan 16, 2026
artonge
force-pushed
the
artonge/feat/better_preview_management
branch
2 times, most recently
from
cd409b6 to
c086985
Compare
Signed-off-by: Louis Chmn <louis@chmn.me>
Signed-off-by: Louis Chmn <louis@chmn.me>
The server only servers sizes that are multiple of 4, so 64, 256, 1024, 4096. Signed-off-by: Louis Chmn <louis@chmn.me>
Signed-off-by: Louis Chmn <louis@chmn.me>
The virtual list do not render anything further than 0.5 anyway. Signed-off-by: Louis Chmn <louis@chmn.me>
Signed-off-by: Louis Chmn <louis@chmn.me>
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
force-pushed
the
artonge/feat/better_preview_management
branch
from
c086985 to
cfc7b8c
Compare
Collaborator
Author
|
Cypress failure related to the sidebar API change |
This was referenced Jan 16, 2026
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.