Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the location entry if Maps is disabled and user is not an admin #343

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Hide the location entry if Maps is disabled and user is not an admin #343

merged 1 commit into from
Jun 9, 2020

Conversation

georgehrke
Copy link
Member

To reproduce:

  • Disable Maps app
  • Login as non-admin user
  • Click the "Location" menu entry:

It will show you this error message:
F7CC82A7-8F94-4827-B034-2852D480DB71

Only admins can access this page.

Solution:

  • Do not display the "Location" menu entry if Maps is disabled and the current user is no admin.

@georgehrke georgehrke added the 3. to review Waiting for reviews label May 28, 2020
@juliushaertl
Copy link
Member

Bundles seem not up to date 😉

@georgehrke
Copy link
Member Author

Bundles seem not up to date 😉

No idea where that error is coming from. This is branched off directly from master and i just committed all the files make changed.

@skjnldsv
Copy link
Member

skjnldsv commented Jun 5, 2020

/compile amend /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working and removed 3. to review Waiting for reviews labels Jun 5, 2020
ChristophWurst
ChristophWurst reviewed Jun 5, 2020
View reviewed changes
src/Photos.vue Outdated Show resolved Hide resolved
@georgehrke
Hide the location entry if Maps is disabled and user is not an admin
e1a2dd0 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/noid/hide_location_if_disabled_and_non_admin branch from 77c50b6 to e1a2dd0 Compare June 5, 2020 08:36
@skjnldsv skjnldsv merged commit db0f7aa into master Jun 9, 2020
@skjnldsv skjnldsv deleted the bugfix/noid/hide_location_if_disabled_and_non_admin branch June 9, 2020 13:52
@skjnldsv
Copy link
Member

skjnldsv commented Jun 9, 2020

/backport to stable19

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jun 9, 2020
@skjnldsv
Copy link
Member

skjnldsv commented Jun 9, 2020

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 9, 2020
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Jun 9, 2020
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 9, 2020
Merged
@skjnldsv skjnldsv mentioned this pull request Jul 14, 2020
Closed
@joshtrichards joshtrichards mentioned this pull request Jul 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@georgehrke @juliushaertl @skjnldsv @ChristophWurst