Instant feel #488
Merged
Instant feel #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikescops
added
enhancement
|
/compile amend / |
skjnldsv
reviewed
Oct 16, 2020
lib/Controller/PageController.php
Outdated
|
|
||
| $policy = new ContentSecurityPolicy(); | ||
| $policy->addAllowedWorkerSrcDomain("'self'"); | ||
| $policy->addAllowedScriptDomain('blob:'); |
There was a problem hiding this comment.
how is the script all of a sudden a blob?
There was a problem hiding this comment.
I followed this, but I may be totally wrong https://medium.com/@krishnachirumamilla/content-security-policy-worker-src-cd06ecfa2fe8
There was a problem hiding this comment.
@rullzer I updated it to be "self"
There was a problem hiding this comment.
ah ok I know why it is confusing me. Normally we only run it with nonce.
Self is a lot better yeah.
And we can always thighen it later on.
npmbuildbot-nextcloud
bot
force-pushed
the
feature/instant-feel
branch
from
016285d to
ee35252
Compare
|
Tested and works nicely for me 👍 |
skjnldsv
reviewed
Oct 17, 2020
Mikescops
force-pushed
the
feature/instant-feel
branch
from
ee35252 to
a8b9203
Compare
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
feature/instant-feel
branch
from
2898b92 to
86444e2
Compare
Mikescops
force-pushed
the
feature/instant-feel
branch
from
86444e2 to
ac33771
Compare
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
feature/instant-feel
branch
from
ac33771 to
04da01e
Compare
jancborchardt
approved these changes
Oct 22, 2020
skjnldsv
approved these changes
Oct 23, 2020
|
Please rebase and ship production files :) |
Mikescops
force-pushed
the
feature/instant-feel
branch
2 times, most recently
from
fd06f48 to
e4f985d
Compare
Signed-off-by: Corentin Mors <corentin.mors@dashlane.com>
Mikescops
force-pushed
the
feature/instant-feel
branch
from
e4f985d to
b28469b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a Service Worker to cache images and improve display of already loaded images.
Thanks a lot to @skjnldsv for the help here and there.
The gallery feels so great now!
Closes #232