Block viewer loop on timeline #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Oct 19, 2020
|
@jancborchardt do you have the latest viewer version? |
Signed-off-by: Corentin Mors <corentin.mors@dashlane.com>
Mikescops
force-pushed
the
feature/block-viewer-loop-on-timeline
branch
from
55271a8 to
df6db0e
Compare
That was the issue of course, always forgetting about cross-app dependencies. :) Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On timeline going from first picture to last was not ideal as there is infinite scroll, so it was going to the last already loaded picture.
Also this feels not natural to loop over a timeline.