Fix default previews #950
Merged
Fix default previews #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
skjnldsv
reviewed
Jan 7, 2022
| @@ -29,6 +29,15 @@ webpackRules.RULE_SCSS.use = [ | |||
| }, | |||
| ] | |||
|
|
|||
| // Load raw SVGs to be able to inject them via v-html | |||
| webpackRules.RULE_ASSETS.test = /\.(png|jpe?g|gif|woff2?|eot|ttf)$/ | |||
| webpackRules.RULE_RAW_SVGS = { | |||
There was a problem hiding this comment.
Fancy 😍
Love that we can do that and it stays clean!
skjnldsv
approved these changes
Jan 7, 2022
|
/backport to stable23 |
backportbot-nextcloud
bot
added
the
backport-request
|
/backport to stable22 |
|
/backport to stable21 |
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable21 failed. Please do this backport manually. |
st3iny
added a commit
that referenced
this pull request
Jan 7, 2022
Backport of #950 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
added a commit
that referenced
this pull request
Jan 7, 2022
Backport of #950 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
This was referenced Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #909
Some default preview SVGs are not shown correctly because they are imported using the wrong loader. In some places (ref #842) this has already been fixed.
I changed some webpack rules to force the usage of
raw-loaderfor all SVGs to bypass the!raw-loader!...hack. This is needed because they are inserted usingv-htmland the default loader (asset/inline) from our shared config producesdata:image/svg+xmlblobs.PS: The attribute
xlink:hrefis deprecated in favor of justhref(ref https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href).