fix: Add visual loading feedback for polls list

[susnux]

• Resolves Visual change request: Change the "You have no polls" message with a spinner #3438

[dartcafe]

@artonge, @susnux

I am very happy if someone helps developing here, but I would like to have a chance for review. Especvially, if I am developing some maintenace issues right in this files.

A little bit of coordination would be nice, before merging into a repo, which is developed for years by only one person.

[dartcafe]

And to make it more funny, this issue is topic of the maintenance, too.

[artonge]

A little bit of coordination would be nice, before merging into a repo, which is developed for years by only one person.

Hey @dartcafe, this was indeed inconsiderate. I was not aware that this app was actively maintained, and just stormed into it due to an assignment. I am really sorry about it. I'll ensure that you have a say on any following PR.

[dartcafe]

I can revert my commit locally, since I used a similar approach which a flag in the store but stayed with the overlay. I am fine with your solution, but there are more spinners used elsewhere (which I guess are broken).

For consistency it would be good to use the same approach there so the LoadingOverlay can be removed.

[dartcafe]

I was not aware that this app was actively maintained

Well the releases tell another story 😉

[sorbaugh]

Hello dartcafe, I'd also like to apologize for making changes without your review and coordination. 🙏 To be transparent, we are facing pressure and urgency due to a support case with a customer that heavily uses Polls and is encountering some performance issues.

In the spirit of not bypassing your role as the maintainer and continue on a more collaborative way, the changes we made are:

• Make the My Polls app the default view
• Add a spinner as feedback to the user for the loading time
• Attempt to optimize the query for My Polls (in our test the loading time was reduced from 50ish seconds to 30) This was the PR: [stable6] Perf improvements for stable-6 for 26 branch #3445

If you have input on what could be done to bring the time down to, say, 10 seconds, your input would be invaluable :)

[dartcafe]

Hello dartcafe, I'd also like to apologize for making changes without your review and coordination. 🙏

@sorbaugh I understand your point. And BTW: Things happen. Don't care.

Find my answers here

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!