Allow to remove the poll list from the navigation by admin setting #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
dartcafe
commented
Apr 29, 2024
| @@ -131,6 +131,7 @@ export default { | |||
| ...mapState({ | |||
| isPollCreationAllowed: (state) => state.polls.meta.permissions.pollCreationAllowed, | |||
There was a problem hiding this comment.
@come-nc
Watch the changed structure. For the stable-6 branch, the mapping should not chbe changed. (meta.* does not exist there in the store.)
come-nc
reviewed
Apr 29, 2024
This was referenced Apr 30, 2024
dartcafe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow deacivating loading polls inside the navigation out of performance reasons
This PR may help to increase the performance of loading polls referring this observations, by adding a setting for diabloing loading the polls list into the navigation.
@come-nc I separated this changes from the main PR, so it should be possible to backport them to the stable-6 branch.