Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Perf improvements for stable-6 for 26 branch #3489

Closed
wants to merge 3 commits into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 7, 2024

Backport of #3445

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

come-nc added 3 commits May 7, 2024 14:40
Saves a few DB requests

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Avoid a DB request for each poll, instead use the data we just got from
 the full list.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Not pretty but avoids a few DB calls. Ideally we should not do these

requests at all, I do not really understand this share part in Acl.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

[skip ci]
@backportbot backportbot bot requested review from artonge and come-nc May 7, 2024 14:40
@artonge artonge changed the title [master] [stable6] Perf improvements for stable-6 for 26 branch [master] Perf improvements for stable-6 for 26 branch May 7, 2024
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acl.php changed from version 6, this need more tweaks.

@dartcafe
Copy link
Collaborator

dartcafe commented May 7, 2024

You confuse me. What do you want to backport?

@dartcafe dartcafe self-requested a review May 7, 2024 18:33
Copy link
Collaborator

@dartcafe dartcafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please close this PR. Backport from stable-6 to master suicidal.

@artonge artonge closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants