Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of chunked loading and leaner pollItems #3492

Merged
merged 7 commits into from
May 8, 2024

Conversation

dartcafe
Copy link
Collaborator

@dartcafe dartcafe commented May 8, 2024

dartcafe added 4 commits May 8, 2024 07:08
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe added this to the 6.3 milestone May 8, 2024
@dartcafe dartcafe requested review from ArtificialOwl and artonge May 8, 2024 05:26
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe changed the title Backport/3479/stable-6 Backport of chunked loading and leaner pollItems May 8, 2024
dartcafe added 2 commits May 8, 2024 07:55
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sane but I did not test it.

@dartcafe
Copy link
Collaborator Author

dartcafe commented May 8, 2024

I tested it and it did what it should, but I would feel better, if I got some feedback from a beta2 test.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if pagination works. I tried to test it locally with 27 polls and all of them are loaded right away.

In the left sidebar only 6 are shown. After clicking on Show all it loads and lists all polls.

@dartcafe
Copy link
Collaborator Author

dartcafe commented May 8, 2024

I'm not sure if pagination works. I tried to test it locally with 27 polls and all of them are loaded right away.

In the left sidebar only 6 are shown. After clicking on Show all it loads and lists all polls.

Initially the first 40 items get loaded, because the observer is visible before the rendering of the first items is ready.

@dartcafe dartcafe merged commit 52d7672 into stable-6 May 8, 2024
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/3479/stable-6 branch May 8, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants