-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of chunked loading and leaner pollItems #3492
Conversation
dartcafe
commented
May 8, 2024
•
edited
Loading
edited
- Manual backport of Enable chunk loading polls in list and limit polls in navigation. #3479
- chunked loading of 20 poll items
- limit number of poll items in nav to 6
- selective manual backport of #Updating pr-feedback.yml workflow from template #3456
- reduced transition time
- leaner PollItem for a leaner pollList dom (better flexbox)
- aligned navigation footer (cosmetic)
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks sane but I did not test it.
I tested it and it did what it should, but I would feel better, if I got some feedback from a beta2 test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if pagination works. I tried to test it locally with 27 polls and all of them are loaded right away.
In the left sidebar only 6 are shown. After clicking on Show all
it loads and lists all polls.
Initially the first 40 items get loaded, because the observer is visible before the rendering of the first items is ready. |