Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update workflows from templates #3670

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

nextcloud-command
Copy link

This PR was automatically generated by the workflow dispatcher
Please check that there are no reverted changes before merging ⚠

See templates in https://github.com/nextcloud/.github

@nextcloud-command nextcloud-command added 3. to review automated dependencies Pull requests that update a dependency file labels Aug 22, 2024
@dartcafe dartcafe requested review from kesselb and hamza221 August 25, 2024 21:31
@dartcafe
Copy link
Collaborator

@hamza221 @kesselb Could you please have a look to this pr. It would revert #3668

@kesselb
Copy link
Collaborator

kesselb commented Aug 26, 2024

Thanks for the ping, I reverted the changes to the workflow.

I'm see three options:

  1. Change the makefile to use /build/artifacts
  2. Revert the workflow update when an update is dispatched
  3. Update https://github.com/nextcloud/.github/blob/master/workflow-templates/appstore-build-publish.yml to read the path from an env variable.

skjnldsv and others added 2 commits August 26, 2024 23:59
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@AndyScherzinger AndyScherzinger force-pushed the automated/update-workflows/default branch from 3a2f527 to a906990 Compare August 26, 2024 21:59
@AndyScherzinger
Copy link
Member

The remaining changes seem fine to merge, the PR feedback change is fine since the removed handles are in the username file now, so they aren't missing, just in a different location.

As for the publishing part, kesselb's options in #3670 (comment) are also correct and any could be chosen now or in the future. My personal take on the options would be to go for option (1) since that will make it work for future updates of the workflow from the org template. But that is just my opinion. Any of the 3 are valid of course.

@dartcafe dartcafe merged commit e60533b into master Sep 6, 2024
21 checks passed
@AndyScherzinger AndyScherzinger deleted the automated/update-workflows/default branch September 7, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review automated dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants