Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid expensive index recreation #3694

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Avoid expensive index recreation #3694

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
263d813
remove index removals
dartcafe Sep 5, 2024
8ff343c
Add a warning to the rebuild command
dartcafe Sep 5, 2024
c6fda61
changelog
dartcafe Sep 5, 2024
1ecc983
I hate my own typos
dartcafe Sep 6, 2024
f33f43d
cs-fix
dartcafe Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
<repair-steps>
<pre-migration>
<step>OCA\Polls\Migration\RepairSteps\RemoveObsoleteMigrations</step>
<step>OCA\Polls\Migration\RepairSteps\RemoveIndices</step>
</pre-migration>
<post-migration>
<step>OCA\Polls\Migration\RepairSteps\DropOrphanedTables</step>
Expand Down
12 changes: 9 additions & 3 deletions lib/Command/Db/Rebuild.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?php

declare(strict_types=1);
/**
* SPDX-FileCopyrightText: 2021 Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
/**
* SPDX-FileCopyrightText: 2021 Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

namespace OCA\Polls\Command\Db;
Expand All @@ -23,6 +23,12 @@ class Rebuild extends Command {
protected array $operationHints = [
'All polls tables will get checked against the current schema.',
'NO data migration will be executed, so make sure you have a backup of your database.',
'',
'*****************************',
'** Please understand **',
'*****************************',
'The process will also recreate all indices and foreign key constraints.',
'This can lead to a database performance impact on the app after the recreation is done.',
];

public function __construct(
Expand Down