Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user search by email #3777

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix user search by email #3777

merged 2 commits into from
Nov 19, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 14, 2024

Searching for users to share with by email was broken.
This is due to 2 problems:

  1. The subname key for users had the wrong casing subName instead of subname
  2. The frontend filtering was active despite not being needed as backend already returns a filtered list
Before After
Copie d'écran_20241114_175310 Copie d'écran_20241114_175142

@dartcafe Is it safe to rename subName to subname or is used elsewhere? The only instance I could find is https://github.com/nextcloud/polls/blob/master/src/js/store/modules/acl.js#L16 and it looks pretty safe to rename if needed.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…earch result

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc requested a review from dartcafe November 14, 2024 16:55
@come-nc come-nc self-assigned this Nov 14, 2024
@dartcafe
Copy link
Collaborator

Renaming the subname seems to be no problem.
As far as I remember, removing the filter removed the highlighting as well, since the match may also occur i.e. with the company name of a contact. But this seems to be no more the case.

@dartcafe
Copy link
Collaborator

Just for reference: nextcloud-libraries/nextcloud-vue#6219

@come-nc
Copy link
Contributor Author

come-nc commented Nov 19, 2024

@dartcafe Can this be merged? Should I ask the bot to "backport" to next?

@dartcafe
Copy link
Collaborator

Sure, I approved. 😉

@come-nc come-nc merged commit 9334a6a into master Nov 19, 2024
21 checks passed
@dartcafe
Copy link
Collaborator

@come-nc Ah, no, backport not necessary. I did the backport already manually, just forgot to link that.

@dartcafe dartcafe added this to the 7.2.5 milestone Nov 19, 2024
@AndyScherzinger AndyScherzinger deleted the fix/fix-user-search-by-email branch November 19, 2024 22:47
@come-nc
Copy link
Contributor Author

come-nc commented Nov 21, 2024

@dartcafe Would you consider releasing 7.2.5 so that this fix makes it to the appstore?

@dartcafe
Copy link
Collaborator

@come-nc I released 7.2.5 yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants