Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.2 #794

Merged
merged 59 commits into from
Jan 31, 2020
Merged

Version 1.2 #794

merged 59 commits into from
Jan 31, 2020

Conversation

dartcafe
Copy link
Collaborator

@dartcafe dartcafe commented Jan 28, 2020

main changes in this release:

internals

  • updated dependencies
  • eleminating publicVote.vue and use vote.vue for public votes
  • consolidated routes (PageController)
  • update to nextcloud 1.3.0
  • minor UX optimizations

dartcafe and others added 30 commits January 24, 2020 17:18
Allow site user to vote in hidden poll via public link #779
Optimization access to shared polls
Update @nextcloud/vue and dev dependencies
@Dennis1993
Copy link

I've installed the neu version and it is much better for new user with the modal window to enter the name! Good job!

I don't know how long the translation needs, I post some not correct translations here. I don't know if its fixed then you can ignore it :)

image

image

@dartcafe
Copy link
Collaborator Author

Translations are only triggered from and added to the master branch.

@tortuetorche
Copy link
Contributor

tortuetorche commented Jan 30, 2020

Hi @dartcafe,

Translations are only triggered from and added to the master branch.

FYI, the Shift all date options options (minute, hour, day, week, month, year) are not translated and translatable in Transifex.
Even in the version-1.2 branch, these options don't look translatable, see references below.

References:

Have a good day,
Tortue Torche

@dartcafe
Copy link
Collaborator Author

FYI, the Shift all date options options (minute, hour, day, week, month, year) are not translated

Yep. Correct, because the array is also used as key for the shift span. If you mind, you could create an issue for that.

@dartcafe
Copy link
Collaborator Author

@v1r0x It seems, everything is working well. I will merge this PR, so the translations can be added.

@dartcafe dartcafe merged commit 1147971 into master Jan 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the version-1.2 branch January 31, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants