Delete poll permanently

[v1r0x]

fix #801

[tortuetorche]

Hi @v1r0x,

I think, you should rebase this branch against master branch to pass tests

Have a good day,
Tortue Torche

[dartcafe]

Old orphaned entries got removed within the migration and permanent deletion works too.

unprocessed log entries get deleted too. Which means, that some notificatons will never be sent under some circumstances. A valuable price IMHO.

[dartcafe]

Tavis can be ignored, because it bases on a known error, which is fixed in the master branch. In the end there are no valuable tests...

[splitt3r]

Any reason for not using the DELETE verb?

Suggested change

	['name' => 'poll#deletePermanently', 'url' => '/polls/delete/permanent/{pollId}', 'verb' => 'GET'],
	['name' => 'poll#deletePermanently', 'url' => '/polls/delete/permanent/{pollId}', 'verb' => 'DELETE'],

[v1r0x]

Itried it, but it didn't work. Thus I thought this isn't supported in NC

[splitt3r]

I think it should 😁 a quick research gave me:

https://github.com/nextcloud/spreed/blob/master/appinfo/routes.php#L274-L282

...
[
		'name' => 'Room#leaveRoom',
		'url' => '/api/{apiVersion}/room/{token}/participants/active',
		'verb' => 'DELETE',
		...
]
...

https://github.com/nextcloud/spreed/blob/master/src/services/participantsService.js#L75

...
const leaveConversationSync = function(token) {
	axios.delete(generateOcsUrl('apps/spreed/api/v1/room', 2) + token + '/participants/active')
}
...

[v1r0x]

For some strange reason it worked fine this time 😕 Maybe I did something wrong last time. Will push a fix when at my dev machine.

[dartcafe]

FYI. Building works well on windows machines with some tools. Only signing is an issue.

[dartcafe]

Routes are still a little bit unsorted and could need some optimization. More verb using.

[dartcafe]

@v1r0x Any further to do here?

[dartcafe]

I solved the merge conflict and changed to ButtonDiv.
After pull, make an npm install to resolve the dependencies merged from master!

[v1r0x]

Changing verb from get to delete is still not done. Beside that I'm ready to merge. Will fix on monday.

[dartcafe]

Changing verb from get to delete is still not done

Not really important for now, IMHO. It works the way, you resolved it. As the routes need some refactoring, this could be done later, together with the rest and maybe by switching to ressources in the routes.php.

[v1r0x]

Then lgtm :)

[dartcafe]

lgtmt
👍 🦁

Will be solved in another PR.