Simple calendar integration #860
Conversation
References: Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com> nextcloud#121, nextcloud#136 and nextcloud#411
tortuetorche
force-pushed
the
calendarNewEvent
branch
from
cc8d5ae to
aac0c8b
Compare
| :class="{ | ||
| primary: isWinner, | ||
| 'icon-calendar': isWinner, | ||
| 'icon-calendar-000': !isWinner |
There was a problem hiding this comment.
You could put this into the component as template, add some props and make it reusable.
| @@ -31,6 +31,12 @@ | |||
| <PollItemText v-if="poll.type === 'textPoll'" :option="option" /> | |||
| <PollItemDate v-if="poll.type === 'datePoll'" :option="option" /> | |||
|
|
|||
| <div v-if="acl.allowEdit && poll.type === 'datePoll'" class="new-event"> | |||
| <a class="button icon-calendar-000" | |||
| :title="t('polls', 'Add a calendar event')" | |||
There was a problem hiding this comment.
... and replace this with the component too.
| /** | ||
| * @NoAdminRequired | ||
| * @return bool | ||
| */ | ||
| public function getAllowAddEvent(): bool { | ||
| return ( | ||
| $this->getAllowEdit() | ||
| && $this->poll->getType() === 'datePoll' | ||
| && $this->appManager->isEnabledForUser('calendar') | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
@tortuetorche I added a new check to the acl: getAllowAddEvent().
It checks the access to the calendar app and integrates your condition.
|
@tortuetorche Are you planning to continue this? |
|
Hi @dartcafe Sorry, not in the next weeks... Have a good day, |
|
I think, too much has changed in the core of polls. At least, with nextcloud/server#20154 a new approach makes sense, since we can do this in the backend. I would consider closing this and wait for nextcloud/server#20154 |
References:
#121, #136 and #411