Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete Country list #241

Closed
arenasa70 opened this issue Oct 11, 2019 · 5 comments · Fixed by #277
Closed

Incomplete Country list #241

arenasa70 opened this issue Oct 11, 2019 · 5 comments · Fixed by #277
Labels
0. Needs triage bug Something isn't working help wanted Extra attention is needed

Comments

@arenasa70
Copy link

Steps to reproduce

  1. Login ad Administrator
  2. Goto /settings/user/privacy
  3. On the Where's your data section select a country, try Aruba, Curacao, Bonair, Sint Maarten

Expected behaviour

Find any country,like in the ISO Country codes list https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes

Actual behaviour

A lot of countries can't be set.

Server configuration

Nextcloud version: 16.0.5

**Where did you install Nextcloud from: linuxserver/nextcloud:amd64-latest Docker

@gary-kim gary-kim transferred this issue from nextcloud/server Oct 11, 2019
@gary-kim gary-kim added 0. Needs triage bug Something isn't working labels Oct 11, 2019
@kesselb
Copy link
Contributor

kesselb commented Oct 11, 2019

We could use something like: https://www.npmjs.com/package/country-codes-list

This was referenced Nov 28, 2019
@georgehrke georgehrke added the help wanted Extra attention is needed label Nov 28, 2019
@georgehrke georgehrke changed the title Incomplete Country list in settings/user/privacy/Where's your data Incomplete Country list Nov 28, 2019
@georgehrke
Copy link
Member

The solution proposed by @kesselb in #248 is the way to go, we just need to find a way to have the list of countries translated.

@georgehrke
Copy link
Member

@TP75 Please see my comments in #248
I don't see how gettext can help us there. We already have a way of extracting translatable strings, the problem is that the strings that we need to translate are hidden deep inside a npm module not following our standard.

@TP75
Copy link

TP75 commented Nov 28, 2019

@TP75 Please see my comments in #248

Please accept my apologies. However, IMHO the comments look too basic for me to truly grasp the issue.

One may not underestimate the power and flexibility of the gettext library ans set of function. I trust the NC developers in being agile and flexible.

Happy hacking.
🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants