Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing regions from ISO 3166 #277

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Nov 30, 2019

Fix #241, Close #248

Added the missing regions from https://www.iso.org/obp/ui/#search/code/ to nameProvider.

  1. I don't know a good way how to solve this with a external npm package. There are some iso 3166 packages with l10n but they only support a subset of nextclouds languages.
  2. Adding some "build script" to create a list from the npm package and update nameProviders.js seems to be possible but adds a lot of additional complexity.

Also renamed country to region because it's less misleading. At least every item from the above list is a region. The map is still wrong but people can pick their region ;)

@kesselb kesselb changed the title Update countrylist2 Add missing regions from ISO 3166 Nov 30, 2019
@kesselb kesselb requested a review from georgehrke November 30, 2019 15:37
@kesselb kesselb added 3. to review enhancement New feature or request labels Nov 30, 2019
https://www.iso.org/obp/ui/#search
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@georgehrke georgehrke force-pushed the update-countrylist2 branch from 417ad55 to a4c2fd6 Compare April 20, 2020 10:56
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@georgehrke georgehrke force-pushed the update-countrylist2 branch from a4c2fd6 to 68b39a3 Compare April 20, 2020 10:57
@georgehrke
Copy link
Member

@kesselb I took the liberty to rebase your PR.

@ChristophWurst ChristophWurst merged commit 80eb15a into master Apr 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-countrylist2 branch April 20, 2020 12:00
@rullzer rullzer mentioned this pull request Apr 21, 2020
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete Country list
3 participants