Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Administrator access wording #1142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/privacy-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/privacy-main.js.map

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions src/components/AdminAccess.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
<template>
<div class="admin">
<h3>{{ t('privacy', 'Administrators') }}</h3>
<p class="admin__desc">
{{ t('privacy', 'The following users are designated administrators and may potentially have access to your data through system storage or backups. However, they do not have easy access to your data via the web interface or client applications.') }}
</p>

<NcLoadingIcon v-if="isLoading"
:name="t('privacy', 'Loading administrators …')"
Expand Down Expand Up @@ -120,7 +123,7 @@
const url = generateUrl('/apps/privacy/api/admins')
try {
const resp = await axios.get(url)
Vue.set(this, 'admins', resp.data)

Check warning on line 126 in src/components/AdminAccess.vue

View workflow job for this annotation

GitHub Actions / NPM lint

Caution: `Vue` also has a named export `set`. Check if you meant to write `import {set} from 'vue'` instead
} catch (error) {
console.error(error)
showError(t('privacy', 'Error loading additional administrator.'))
Expand Down Expand Up @@ -204,6 +207,11 @@

<style lang="scss" scoped>
.admin {
&__desc {
color: var(--color-text-maxcontrast);
margin-bottom: calc(var(--default-grid-baseline) * 4);
}

&__controls {
display: flex;
flex-direction: column;
Expand Down
Loading