-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to new nextcloud npm packages #273
Conversation
856559f
to
2a2f88c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you're still working on this but I noticed a few things. Hope you don't mind 😄
Bump! |
Yes, it's on my todo list for this week, so we can have this in 19 |
ahah, sorry, I was looking for apps that uses |
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
3745be4
to
ec9eb4b
Compare
@@ -1,55 +1,55 @@ | |||
const path = require('path') | |||
const StyleLintPlugin = require('stylelint-webpack-plugin') | |||
const { VueLoaderPlugin } = require('vue-loader') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the kind of apps for which a standard webpack config would works flawlessly too!
@ChristophWurst skjnldsv/vueexample#238
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copy and pasted it from the app-tutorial ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :)
I mean, we discussed it last week on the js channel, about a nice vue webpack library which we can easily use in our apps and extend!
Christoph was doubting it, but we have tons of apps who have pretty much all the same webpack files and would benefit from just relying on an external template I think!
What do you think @georgehrke ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally in favour of everything that makes things easier for standard apps. It should work for most apps (mostly excluding those which rely on async imports for moment locales).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to deploy this and integrate it in other places!
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
ec9eb4b
to
bc07cb3
Compare
fixes #244
What this pull-request does:
nextcloud-*
packages to@nextcloud/*