Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 28 Files headers compatibility #637

Merged
merged 1 commit into from
Sep 5, 2023
Merged

feat: 28 Files headers compatibility #637

merged 1 commit into from
Sep 5, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 11, 2023 •
edited
Loading

@skjnldsv skjnldsv changed the title feat: 28 files compatibility feat: 28 Files headers compatibility Aug 11, 2023
@skjnldsv skjnldsv self-assigned this Aug 11, 2023
skjnldsv
skjnldsv commented Aug 11, 2023
View reviewed changes
src/main.js Show resolved Hide resolved
@skjnldsv skjnldsv mentioned this pull request Aug 16, 2023
Merged
juliushaertl
juliushaertl approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works with the matching server branch 👍

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@skjnldsv @juliushaertl
feat: 28 files compatibility
b04dccf 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@juliushaertl
Copy link
Member

Pushed a rebased version, but somehow github doesn't pick it up on the PR.

@juliushaertl juliushaertl force-pushed the feat/28-files branch 2 times, most recently from 2a272aa to b04dccf Compare September 5, 2023 16:44
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 5, 2023

Seems good now! 🚀

@skjnldsv skjnldsv merged commit 244a991 into master Sep 5, 2023
18 checks passed
@skjnldsv skjnldsv deleted the feat/28-files branch September 5, 2023 17:32
@Pytal Pytal mentioned this pull request Sep 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees

@skjnldsv skjnldsv

Labels
4. to release feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @juliushaertl