Revert "perf(dashboard): implement widget item api v2" #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Oct 30, 2023
Pytal
approved these changes
Oct 30, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
|
Can we somehow add a selector to the widget item API? So we could just use a very small script to add viewer support and still benefit from not needed to provide a full dashboard bundle |
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
|
@ChristophWurst @st3iny we're entering RC1, if this revert is important, it needs to get in asap! 👍 Otherwise, either close or change the milestone 🙏 |
st3iny
force-pushed
the
revert/644
branch
2 times, most recently
from
2bc30b3
to
014e258
Compare
|
I rebased, resolved conflicts and tested again. I also fixed CI to finally make it green. |
|
@skjnldsv Your call regarding the merge. I'm not sure given that we had rc.1 already. |
|
|
This reverts commit 52feace. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 52feace.
I tested this locally and the dashboard widgets works like it did before (builtin viewer etc.).