Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mail confirmation optional #248

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Make mail confirmation optional #248

merged 3 commits into from
Nov 17, 2020

Conversation

Nienzu
Copy link
Member

@Nienzu Nienzu commented Oct 13, 2020 •
edited by nickvergessen
Loading

fix #65

@Nienzu
Copy link
Member Author

Nienzu commented Oct 13, 2020

fix #65

@Nienzu Nienzu force-pushed the mail_confirmation_optional branch 2 times, most recently from 4057644 to 07bc320 Compare October 13, 2020 05:47
@Nienzu Nienzu force-pushed the mail_confirmation_optional branch 4 times, most recently from 347217d to ef1f984 Compare October 13, 2020 08:23
@Nienzu Nienzu force-pushed the mail_confirmation_optional branch 5 times, most recently from 2c31543 to 78e02b9 Compare October 20, 2020 03:36
@Nienzu
Make mail confirmation optional
bdb40a2 
Signed-off-by: nienzu <ibqqz0602@gmail.com>
@Nienzu
Copy link
Member Author

Nienzu commented Oct 20, 2020

@nickvergessen
Please help me review this PR. Thank you : )

@nickvergessen
Copy link
Member

Hi, sorry it's on my todo to look at this, but I just don't have the time currently. But I will look at it before the next release of the app.

@Nienzu
Copy link
Member Author

Nienzu commented Oct 30, 2020

@nickvergessen It's ok! Thanks for telling me 👍
Look forward to your review : )

@nickvergessen
Split the flows for less code intendation
ab64168 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
p already writes the text, no need to echo
ea57938 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member

Looks good, I fixed two minor things directly so I can merge it immediately.

@nickvergessen nickvergessen merged commit 303be22 into nextcloud:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: settings ⚙️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make mail confirmation optional
2 participants
@Nienzu @nickvergessen