Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terms of service integration #293

Merged
merged 5 commits into from
Apr 14, 2021
Merged

Terms of service integration #293

merged 5 commits into from
Apr 14, 2021

Conversation

nickvergessen
Copy link
Member

Fix #287

@nickvergessen
Allow apps to listen to the steps and validate the form data
1e907c2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add a body part for the ToS app
f518703 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Apr 9, 2021
Merged
1 task
@nickvergessen
Fix event name
6eb0794 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

ToS PR is at nextcloud/terms_of_service#511

@nickvergessen
Fix unit tests
da99906 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen marked this pull request as ready for review April 13, 2021 14:05
PVince81
PVince81 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine 👍

@PVince81
Copy link
Member

seems the linter wants some changes though

@nickvergessen
Fix linter
48b521f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
danxuliu
danxuliu approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@nickvergessen nickvergessen merged commit 0d85552 into master Apr 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/287/terms-of-service-integration branch April 14, 2021 09:40
@nickvergessen nickvergessen mentioned this pull request Apr 15, 2021
Merged
@hobbsecky
Copy link

Nice one. Working as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@PVince81 PVince81 PVince81 approved these changes

@Nienzu Nienzu Awaiting requested review from Nienzu

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate with 📜 Terms of service
4 participants
@nickvergessen @PVince81 @hobbsecky @danxuliu