Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make built-in code server setup more stable #3762

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Make built-in code server setup more stable #3762

merged 4 commits into from
Jun 20, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 13, 2024 •
edited
Loading

Best to be reviewed as individual commits for the frontend, backend changes are mostly moving code and adding proper status codes

  • chore: Refactor frontend capabilities to a service to be able to update on the fly
  • fix: Move auto setup of built-in code server to an async request done by the frontend
  • Add typescript support for eslint and fix errors

Can be tested with:

  • occ app:enable richdocumentscode
  • occ config:app:delete richdocuments wopi_url
  • Reload the file list
  • Now a request happens that autoconfigures the built-in code server (if you are admin and it is not configured yet)
  • Once succeeded it will update the capabilities in the frontend which makes the viewer work

Fixes #1282

@juliusknorr juliusknorr requested review from elzody and blizzz June 13, 2024 12:41
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Jun 13, 2024
@juliusknorr juliusknorr added this to the Nextcloud 30 milestone Jun 13, 2024
@juliusknorr juliusknorr mentioned this pull request Jun 13, 2024
Closed
elzody
elzody reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@elzody elzody left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the error

Property oc_isadmin does not exist on type Window & typeof globalThis

Not sure about it

@juliusknorr juliusknorr force-pushed the fix/code-autosetup-async branch from 10dd482 to e9ec318 Compare June 14, 2024 05:30
@juliusknorr
chore: Refactor frontend capabilities to a service to be able to upda…
a509a62 
…te on the fly

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Move auto setup of built-in code server to an async request done…
f42ab52 
… by the frontend

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
chore: Also handle typescript files in eslint
369c33c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Fix eslint errors for typescript files
4158fbe 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the fix/code-autosetup-async branch from e9ec318 to 4158fbe Compare June 14, 2024 08:49
@juliusknorr
Copy link
Member Author

Fixed, I missed to add the types file for those

@juliusknorr juliusknorr requested a review from elzody June 14, 2024 08:50
@juliusknorr juliusknorr merged commit 5b3dbf3 into main Jun 20, 2024
58 of 60 checks passed
@juliusknorr juliusknorr deleted the fix/code-autosetup-async branch June 20, 2024 22:55
@juliusknorr juliusknorr mentioned this pull request Aug 19, 2024
Open
8 tasks
@juliusknorr juliusknorr mentioned this pull request Nov 28, 2024
Closed
@juliusknorr juliusknorr mentioned this pull request Jan 14, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzody elzody elzody approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

RichDocuments built-in CODE causes significant slowdown/timeout issues
2 participants
@juliusknorr @elzody