Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed token generation on public shares #4030

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Sep 12, 2024

  • Target version: main

Summary

This is part of an effort to improve public sharing on the main branch with all the server changes for NC 31.
The issue here was that the sharing token was grabbed from an invisible html element that contained the token, which is no longer present -- the token instead must be gotten via either initial state from files_sharing or via this method using the @nextcloud/sharing library which I think is clearer. It also will be helpful for other things relating to public shares

https://nextcloud-libraries.github.io/nextcloud-sharing/modules/public.html

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@elzody elzody added bug Something isn't working 3. to review Ready to be reviewed dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 12, 2024
@elzody elzody requested a review from juliusknorr September 12, 2024 18:53
@elzody elzody self-assigned this Sep 12, 2024
@juliusknorr
Copy link
Member

juliusknorr commented Sep 12, 2024

There seem to be other occurrences where shareToken is still obtained from an element by id, maybe worth to check those as well separately if they are still in use

@elzody elzody force-pushed the fix/failed-token-generation branch 4 times, most recently from a1d79fe to 9d2bce9 Compare September 17, 2024 07:56
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody force-pushed the fix/failed-token-generation branch from 9d2bce9 to 90c5da5 Compare September 17, 2024 08:08
@elzody elzody merged commit fdfca61 into main Sep 17, 2024
49 of 52 checks passed
@elzody elzody deleted the fix/failed-token-generation branch September 17, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants