fix: failed token generation on public shares #4030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is part of an effort to improve public sharing on the main branch with all the server changes for NC 31.
The issue here was that the sharing token was grabbed from an invisible html element that contained the token, which is no longer present -- the token instead must be gotten via either initial state from files_sharing or via this method using the
@nextcloud/sharing
library which I think is clearer. It also will be helpful for other things relating to public shareshttps://nextcloud-libraries.github.io/nextcloud-sharing/modules/public.html
Checklist