Fix theming migration repair step by passing correct type for argument

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
nextcloud · Jan 10, 2023 · 09099cf · 09099cf
1 parent 4ecf4b4
commit 09099cf
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/apps/theming/lib/Jobs/MigrateBackgroundImages.php b/apps/theming/lib/Jobs/MigrateBackgroundImages.php
@@ -68,10 +68,9 @@ public function __construct(
 		$this->logger = $logger;
 	}
 
-	protected function run($argument): void {
-		if (!isset($argument['stage'])) {
-			// not executed in 25.0.0?!
-			$argument['stage'] = self::STAGE_PREPARE;
+	protected function run(mixed $argument): void {
+		if (!is_array($argument) || !isset($argument['stage'])) {
+			throw new \Exception('Job '.self::class.' called with wrong argument');
 		}
 
 		switch ($argument['stage']) {
@@ -99,10 +98,10 @@ protected function runPreparation(): void {
 			$userIds = $result->fetchAll(\PDO::FETCH_COLUMN);
 			$this->storeUserIdsToProcess($userIds);
 		} catch (\Throwable $t) {
-			$this->jobList->add(self::class, self::STAGE_PREPARE);
+			$this->jobList->add(self::class, ['stage' => self::STAGE_PREPARE]);
 			throw $t;
 		}
-		$this->jobList->add(self::class, self::STAGE_EXECUTE);
+		$this->jobList->add(self::class, ['stage' => self::STAGE_EXECUTE]);
 	}
 
 	/**