Fix populating the array and closing the cursors

Signed-off-by: Joas Schilling <coding@schilljs.com>
nextcloud · Aug 31, 2021 · 1310025 · 1310025
1 parent bd62274
commit 1310025
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/private/Comments/Manager.php b/lib/private/Comments/Manager.php
@@ -654,16 +654,16 @@ public function getNumberOfUnreadCommentsForObjects(string $objectType, array $o
 			$query->andWhere($query->expr()->eq('c.verb', $query->createNamedParameter($verb)));
 		}
 
+		$unreadComments = array_fill_keys($objectIds, 0);
 		foreach (array_chunk($objectIds, 1000) as $chunk) {
 			$query->setParameter('ids', $chunk, IQueryBuilder::PARAM_INT_ARRAY);
-			$result = $query->execute();
 
-			$unreadComments += array_fill_keys($objectIds, 0);
+			$result = $query->executeQuery();
 			while ($row = $result->fetch()) {
 				$unreadComments[$row['object_id']] = (int) $row['num_comments'];
 			}
+			$result->closeCursor();
 		}
-		$result->closeCursor();
 
 		return $unreadComments;
 	}