Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ACLs without \ in the username throw exception
Getting: Error: Undefined offset: 1 at /var/www/html/nextcloud/apps/files_external/lib/Lib/Storage/SMB.php#222 for every ACL with no \ in the username This change deals with users eg. S-5-1-xxx just returning no username for them. Returning a plain username eg. ['', $user] could be a security risk or at least would be incorrect
- Loading branch information
1f95f9b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I found your commit while looking for a fix regarding an error message in nextcloud.
When I wanted to add it I realized that there exists a splitUser() function that basically does the same. The only difference is you return an empty string in case no domain is found whereas splitUser() returns the username part.