cache user folders

nextcloud · Aug 25, 2016 · 2693ae8 · 2693ae8
1 parent b2d3657
commit 2693ae8
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 16 deletions.
diff --git a/lib/private/Files/Node/Root.php b/lib/private/Files/Node/Root.php
@@ -28,6 +28,7 @@
 
 namespace OC\Files\Node;
 
+use OC\Cache\CappedMemoryCache;
 use OC\Files\Mount\Manager;
 use OC\Files\Mount\MountPoint;
 use OCP\Files\NotFoundException;
@@ -71,6 +72,8 @@ class Root extends Folder implements IRootFolder {
 	 */
 	private $user;
 
+	private $userFolderCache;
+
 	/**
 	 * @param \OC\Files\Mount\Manager $manager
 	 * @param \OC\Files\View $view
@@ -81,6 +84,7 @@ public function __construct($manager, $view, $user) {
 		$this->mountManager = $manager;
 		$this->user = $user;
 		$this->emitter = new PublicEmitter();
+		$this->userFolderCache = new CappedMemoryCache();
 	}
 
 	/**
@@ -335,25 +339,31 @@ public function getName() {
 	 * @return \OCP\Files\Folder
 	 */
 	public function getUserFolder($userId) {
-		\OC\Files\Filesystem::initMountPoints($userId);
-		$dir = '/' . $userId;
-		$folder = null;
-
-		try {
-			$folder = $this->get($dir);
-		} catch (NotFoundException $e) {
-			$folder = $this->newFolder($dir);
-		}
+		if (!$this->userFolderCache->hasKey($userId)) {
+			\OC\Files\Filesystem::initMountPoints($userId);
+			$dir = '/' . $userId;
+			$folder = null;
+
+			try {
+				$folder = $this->get($dir);
+			} catch (NotFoundException $e) {
+				$folder = $this->newFolder($dir);
+			}
 
-		$dir = '/files';
-		try {
-			$folder = $folder->get($dir);
-		} catch (NotFoundException $e) {
-			$folder = $folder->newFolder($dir);
-			\OC_Util::copySkeleton($userId, $folder);
+			$dir = '/files';
+			try {
+				$folder = $folder->get($dir);
+			} catch (NotFoundException $e) {
+				$folder = $folder->newFolder($dir);
+				\OC_Util::copySkeleton($userId, $folder);
+			}
+			$this->userFolderCache->set($userId, $folder);
 		}
 
-		return $folder;
+		return $this->userFolderCache->get($userId);
+	}
 
+	public function clearCache() {
+		$this->userFolderCache = new CappedMemoryCache();
 	}
 }
diff --git a/lib/private/legacy/util.php b/lib/private/legacy/util.php
@@ -356,6 +356,7 @@ public static function copyr($source, \OCP\Files\Folder $target) {
 	 */
 	public static function tearDownFS() {
 		\OC\Files\Filesystem::tearDown();
+		\OC::$server->getRootFolder()->clearCache();
 		self::$fsSetup = false;
 		self::$rootMounted = false;
 	}

diff --git a/tests/lib/TestCase.php b/tests/lib/TestCase.php
@@ -24,6 +24,7 @@
 
 use DOMDocument;
 use DOMNode;
+use OC\Cache\CappedMemoryCache;
 use OC\Command\QueueBus;
 use OC\Files\Filesystem;
 use OC\Template\Base;