fixup! fixup! fixup! Fix return type of methods returning false on error

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

lib/private/Files/Filesystem.php

@@ -420,11 +420,8 @@ public static function mount($class, $arguments, $mountpoint) {
 	 * return the path to a local version of the file
 	 * we need this because we can't know if a file is stored local or not from
 	 * outside the filestorage and for some purposes a local file is needed
-	 *
-	 * @param string $path
-	 * @return string
 	 */
-	public static function getLocalFile($path) {
+	public static function getLocalFile(string $path): string|false {
 		return self::$defaultInstance->getLocalFile($path);
 	}
 

lib/private/Files/Storage/LocalTempFileTrait.php

@@ -35,14 +35,10 @@
  * in classes which extend it, e.g. $this->stat() .
  */
 trait LocalTempFileTrait {
-	/** @var string[] */
-	protected $cachedFiles = [];
+	/** @var array<string,string|false> */
+	protected array $cachedFiles = [];
 
-	/**
-	 * @param string $path
-	 * @return string
-	 */
-	protected function getCachedFile($path) {
+	protected function getCachedFile(string $path): string|false {
 		if (!isset($this->cachedFiles[$path])) {
 			$this->cachedFiles[$path] = $this->toTmpFile($path);
 		}
@@ -56,11 +52,7 @@ protected function removeCachedFile($path) {
 		unset($this->cachedFiles[$path]);
 	}
 
-	/**
-	 * @param string $path
-	 * @return string
-	 */
-	protected function toTmpFile($path) { //no longer in the storage api, still useful here
+	protected function toTmpFile(string $path): string|false { //no longer in the storage api, still useful here
 		$source = $this->fopen($path, 'r');
 		if (!$source) {
 			return false;