Merge pull request #37423 from nextcloud/fix/37422-Remove_custom_tool…

…tips_from_entries_of_contacts_menu Replace custom tooltips with native ones of entries in contacts menu.
nextcloud · Mar 29, 2023 · 31f4f41 · 31f4f41
2 parents b129cea + ccf9297
commit 31f4f41
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 13 deletions.
diff --git a/core/src/OC/contactsmenu.js b/core/src/OC/contactsmenu.js
@@ -183,11 +183,6 @@ const ContactsListItemView = View.extend({
 		// Show placeholder if no avatar is available (avatar is rendered as img, not div)
 		this.$('div.avatar').imageplaceholder(this._model.get('fullName'))
 
-		// Show tooltip for top action
-		this.$('.top-action').tooltip({ placement: 'left' })
-		// Show tooltip for second action
-		this.$('.second-action').tooltip({ placement: 'left' })
-
 		return this
 	},
 

diff --git a/core/src/OC/contactsmenu/contact.handlebars b/core/src/OC/contactsmenu/contact.handlebars
@@ -28,7 +28,7 @@
 		</a>
 	{{/if}}
 	{{#if contact.topAction}}
-		<a class="top-action" href="{{contact.topAction.hyperlink}}" title="{{contact.topAction.title}}">
+		<a class="top-action" href="{{contact.topAction.hyperlink}}" title="{{contact.topAction.title}}" aria-label="{{contact.topAction.title}}">
 			<img src="{{contact.topAction.icon}}" alt="{{contact.topAction.title}}">
 		</a>
 	{{/if}}
@@ -49,7 +49,7 @@
 	</div>
 {{/if}}
 {{#if contact.hasTwoActions}}
-<a class="second-action" href="{{contact.secondAction.hyperlink}}" title="{{contact.secondAction.title}}">
+<a class="second-action" href="{{contact.secondAction.hyperlink}}" aria-label="{{contact.secondAction.title}}" title="{{contact.secondAction.title}}">
 	<img src="{{contact.secondAction.icon}}" alt="{{contact.secondAction.title}}">
 </a>
 {{/if}}

diff --git a/dist/core-login.js b/dist/core-login.js
diff --git a/dist/core-login.js.map b/dist/core-login.js.map
diff --git a/dist/core-main.js b/dist/core-main.js
diff --git a/dist/core-main.js.map b/dist/core-main.js.map