Skip to content

Commit

Permalink
fix: added a label element to the NcSelect in update settings
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
  • Loading branch information
emoral435 authored and nextcloud-command committed Jan 27, 2024
1 parent d1e726d commit 35518bc
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 13 deletions.
14 changes: 10 additions & 4 deletions apps/updatenotification/src/components/UpdateNotification.vue
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,9 @@
<em v-html="noteDelayedStableString" />
</p>

<h4>{{ t('updatenotification', 'Notify members of the following groups about available updates:') }}</h4>
<NcSelect v-model="notifyGroups"
id="notify-members-settings-select-wrapper"
:input-label="t('updatenotification', 'Notify members of the following groups about available updates:')"
:options="groups"
:multiple="true"
label="displayname"
Expand Down Expand Up @@ -483,9 +484,6 @@ export default {
}
}
}
h4 {
margin-block-end: 0.7rem;
}
.update-channel-selector {
display: flex;
align-items: center;
Expand Down Expand Up @@ -547,5 +545,13 @@ export default {
.update-menu .icon-star:focus {
background-image: var(--icon-starred);
}
/* override NcSelect styling so that label can have correct width */
#notify-members-settings-select-wrapper {
width: fit-content;
.vs__dropdown-toggle {
min-width: 100%;
}
}
}
</style>
4 changes: 2 additions & 2 deletions dist/614-614.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/614-614.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/core-unsupported-browser.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-unsupported-browser.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/updatenotification-updatenotification.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/updatenotification-updatenotification.js.map

Large diffs are not rendered by default.

0 comments on commit 35518bc

Please sign in to comment.