Skip to content

Commit

Permalink
More explicit empty profile message
Browse files Browse the repository at this point in the history
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
  • Loading branch information
Pytal authored and nextcloud-command committed Nov 25, 2021
1 parent 2d19e2c commit 4185fc2
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions apps/settings/js/vue-settings-personal-info.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/settings/js/vue-settings-personal-info.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/settings/src/constants/AccountPropertyConstants.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const ACCOUNT_PROPERTY_ENUM = Object.freeze({
export const ACCOUNT_PROPERTY_READABLE_ENUM = Object.freeze({
ADDRESS: t('settings', 'Address'),
AVATAR: t('settings', 'Avatar'),
BIOGRAPHY: t('settings', 'About'),
BIOGRAPHY: t('settings', 'Biography'),
DISPLAYNAME: t('settings', 'Full name'),
EMAIL_COLLECTION: t('settings', 'Additional email'),
EMAIL: t('settings', 'Email'),
Expand Down
4 changes: 2 additions & 2 deletions core/js/dist/profile.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/js/dist/profile.js.map

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions core/src/views/Profile.vue
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@
fill-color="var(--color-text-maxcontrast)"
:size="60" />
<h3>{{ emptyProfileMessage }}</h3>
<p>{{ t('core', 'The headline and about sections will show up here') }}</p>
<p>{{ t('core', 'Your added info will show up here') }}</p>
</div>
</template>
</div>
Expand Down Expand Up @@ -258,8 +258,8 @@ export default {

emptyProfileMessage() {
return this.isCurrentUser
? t('core', 'You haven\'t added any info yet')
: t('core', '{user} hasn\'t added any info yet', { user: (this.displayname || this.userId) })
? t('core', 'You haven\'t added a headline or biography yet')
: t('core', '{user} hasn\'t added a headline or biography yet', { user: (this.displayname || this.userId) })
},
},

Expand Down
2 changes: 1 addition & 1 deletion lib/private/Profile/ProfileManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ public function getProfileConfigWithMetadata(IUser $targetUser, ?IUser $visiting
],
IAccountManager::PROPERTY_BIOGRAPHY => [
'appId' => self::CORE_APP_ID,
'displayId' => $this->l10nFactory->get(self::CORE_APP_ID)->t('About'),
'displayId' => $this->l10nFactory->get(self::CORE_APP_ID)->t('Biography'),
],
IAccountManager::PROPERTY_DISPLAYNAME => [
'appId' => self::CORE_APP_ID,
Expand Down

0 comments on commit 4185fc2

Please sign in to comment.