Merge pull request #25879 from nextcloud/fix/user-list-infinite-loading

Fix user list infinite loading state in user settings
nextcloud · Sep 3, 2021 · 46837e2 · 46837e2
2 parents 6a9afe3 + 073a673
commit 46837e2
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 16 deletions.
diff --git a/apps/settings/js/vue-settings-apps-users-management.js b/apps/settings/js/vue-settings-apps-users-management.js
diff --git a/apps/settings/js/vue-settings-apps-users-management.js.map b/apps/settings/js/vue-settings-apps-users-management.js.map
diff --git a/apps/settings/js/vue-settings-users.js b/apps/settings/js/vue-settings-users.js
diff --git a/apps/settings/js/vue-settings-users.js.map b/apps/settings/js/vue-settings-users.js.map
diff --git a/apps/settings/src/components/UserList.vue b/apps/settings/src/components/UserList.vue
@@ -461,8 +461,13 @@ export default {
 				group: this.selectedGroup !== 'disabled' ? this.selectedGroup : '',
 				search: this.searchQuery,
 			})
-				.then((response) => {
-					response ? $state.loaded() : $state.complete()
+				.then((usersCount) => {
+					if (usersCount > 0) {
+						$state.loaded()
+					}
+					if (usersCount < this.usersLimit) {
+						$state.complete()
+					}
 				})
 		},
 

diff --git a/apps/settings/src/store/users.js b/apps/settings/src/store/users.js
@@ -224,11 +224,11 @@ const actions = {
 				cancelToken: searchRequestCancelSource.token,
 			})
 				.then((response) => {
-					if (Object.keys(response.data.ocs.data.users).length > 0) {
+					const usersCount = Object.keys(response.data.ocs.data.users).length
+					if (usersCount > 0) {
 						context.commit('appendUsers', response.data.ocs.data.users)
-						return Object.keys(response.data.ocs.data.users).length >= limit
 					}
-					return false
+					return usersCount
 				})
 				.catch((error) => {
 					if (!axios.isCancel(error)) {
@@ -241,11 +241,11 @@ const actions = {
 			cancelToken: searchRequestCancelSource.token,
 		})
 			.then((response) => {
-				if (Object.keys(response.data.ocs.data.users).length > 0) {
+				const usersCount = Object.keys(response.data.ocs.data.users).length
+				if (usersCount > 0) {
 					context.commit('appendUsers', response.data.ocs.data.users)
-					return Object.keys(response.data.ocs.data.users).length >= limit
 				}
-				return false
+				return usersCount
 			})
 			.catch((error) => {
 				if (!axios.isCancel(error)) {