Validation for existing mountpoint path

nextcloud · Oct 25, 2018 · 4bb6407 · 4bb6407
1 parent 6ad7f32
commit 4bb6407
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/apps/files_external/l10n/en_GB.js b/apps/files_external/l10n/en_GB.js
@@ -45,6 +45,7 @@ OC.L10N.register(
     "Storage with ID \"%d\" not found" : "Storage with ID \"%d\" not found",
     "Invalid backend or authentication mechanism class" : "Invalid backend or authentication mechanism class",
     "Invalid mount point" : "Invalid mount point",
+    "Invalid path of mountpoint" : "Invalid path of mountpoint",
     "Objectstore forbidden" : "Objectstore forbidden",
     "Invalid storage backend \"%s\"" : "Invalid storage backend \"%s\"",
     "Not permitted to use backend \"%s\"" : "Not permitted to use backend \"%s\"",

diff --git a/apps/files_external/l10n/en_GB.json b/apps/files_external/l10n/en_GB.json
@@ -43,6 +43,7 @@
     "Storage with ID \"%d\" not found" : "Storage with ID \"%d\" not found",
     "Invalid backend or authentication mechanism class" : "Invalid backend or authentication mechanism class",
     "Invalid mount point" : "Invalid mount point",
+    "Invalid path of mountpoint" : "Invalid path of mountpoint",
     "Objectstore forbidden" : "Objectstore forbidden",
     "Invalid storage backend \"%s\"" : "Invalid storage backend \"%s\"",
     "Not permitted to use backend \"%s\"" : "Not permitted to use backend \"%s\"",

diff --git a/apps/files_external/lib/Controller/StoragesController.php b/apps/files_external/lib/Controller/StoragesController.php
@@ -152,6 +152,16 @@ protected function validate(StorageConfig $storage) {
 			);
 		}
 
+		$mountPointParentDir = dirname($mountPoint, 1);
+		if ($mountPointParentDir && !\OC\Files\Filesystem::is_dir($mountPointParentDir)) {
+			return new DataResponse(
+				array(
+					'message' => (string)$this->l10n->t('Invalid path of mountpoint')
+				),
+				Http::STATUS_UNPROCESSABLE_ENTITY
+			);
+		}
+
 		if ($storage->getBackendOption('objectstore')) {
 			// objectstore must not be sent from client side
 			return new DataResponse(