Skip to content

Commit

Permalink
Don't use placeholder for password in IE8 & 9
Browse files Browse the repository at this point in the history
* the placeholder is in IE 8 and 9 just set as text and
  styled a bit grey. If the form is then serialized without
  typing something in the placeholder is sent as value
* this fixes that behaviour for the password field and
  properly detects empyt passwords
* fixes #14912
  • Loading branch information
MorrisJobke committed Mar 26, 2015
1 parent c8c722b commit 55e1226
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion settings/js/personal.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,13 @@ $(document).ready(function () {
$('#pass2').showPassword().keyup();
}
$("#passwordbutton").click(function () {
if ($('#pass1').val() !== '' && $('#pass2').val() !== '') {
var isIE8or9 = html.hasClass('lte9');
// FIXME - TODO - once support for IE8 and IE9 is dropped
// for IE8 and IE9 this will check additionally if the typed in password
// is different from the placeholder, because in IE8/9 the placeholder
// is simply set as the value to look like a placeholder
if ($('#pass1').val() !== '' && $('#pass2').val() !== ''
&& !(isIE8or9 && $('#pass2').val() === $('#pass2').attr('placeholder'))) {
// Serialize the data
var post = $("#passwordform").serialize();
$('#passwordchanged').hide();
Expand Down

0 comments on commit 55e1226

Please sign in to comment.