Skip to content

Commit

Permalink
Merge pull request #45359 from nextcloud/backport/45357/stable28
Browse files Browse the repository at this point in the history
[stable28] fix: add ldap_exop_passwd function to sensitive value
  • Loading branch information
nickvergessen authored May 16, 2024
2 parents 55dd808 + 140ca2b commit 5c1c789
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion apps/user_ldap/lib/LDAP.php
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ protected function invokeLDAPMethod(string $func, ...$arguments) {

private function preFunctionCall(string $functionName, array $args): void {
$this->curArgs = $args;
if(strcasecmp($functionName, 'ldap_bind') === 0) {
if(strcasecmp($functionName, 'ldap_bind') === 0 || strcasecmp($functionName, 'ldap_exop_passwd') === 0) {
// The arguments are not key value pairs
// \OCA\User_LDAP\LDAP::bind passes 3 arguments, the 3rd being the pw
// Remove it via direct array access for now, although a better solution could be found mebbe?
Expand Down

0 comments on commit 5c1c789

Please sign in to comment.