Use $var[] = $a instead of array_push - 2x faster

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
nextcloud · Jan 25, 2018 · 870fe20 · 870fe20
1 parent b9bbb89
commit 870fe20
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 10 deletions.
diff --git a/apps/files_versions/lib/Storage.php b/apps/files_versions/lib/Storage.php
@@ -566,7 +566,7 @@ private static function getAllVersions($uid) {
 				$fileData = $file->getData();
 				$filePath = $dir . '/' . $fileData['name'];
 				if ($file['type'] === 'dir') {
-					array_push($dirs, $filePath);
+					$dirs[] = $filePath;
 				} else {
 					$versionsBegin = strrpos($filePath, '.v');
 					$relPathStart = strlen(self::VERSIONS_ROOT);

diff --git a/apps/twofactor_backupcodes/lib/Service/BackupCodeStorage.php b/apps/twofactor_backupcodes/lib/Service/BackupCodeStorage.php
@@ -86,7 +86,7 @@ public function createCodes(IUser $user, $number = 10) {
 			$dbCode->setUsed(0);
 			$this->mapper->insert($dbCode);
 
-			array_push($result, $code);
+			$result[] = $code;
 		}
 
 		$this->publishEvent($user, 'codes_generated');

diff --git a/lib/private/Activity/Manager.php b/lib/private/Activity/Manager.php
@@ -231,7 +231,7 @@ public function publishActivity($app, $subject, $subjectParams, $message, $messa
 	 * @param \Closure $callable
 	 */
 	public function registerConsumer(\Closure $callable) {
-		array_push($this->consumersClosures, $callable);
+		$this->consumersClosures[] = $callable;
 		$this->consumers = [];
 	}
 
@@ -244,7 +244,7 @@ public function registerConsumer(\Closure $callable) {
 	 * @param \Closure $callable
 	 */
 	public function registerExtension(\Closure $callable) {
-		array_push($this->extensionsClosures, $callable);
+		$this->extensionsClosures[] = $callable;
 		$this->extensions = [];
 	}
 

diff --git a/lib/private/AppFramework/DependencyInjection/DIContainer.php b/lib/private/AppFramework/DependencyInjection/DIContainer.php
@@ -335,7 +335,7 @@ public function getServer()
 	 * @return boolean|null
 	 */
 	public function registerMiddleWare($middleWare) {
-		array_push($this->middleWares, $middleWare);
+		$this->middleWares[] = $middleWare;
 	}
 
 	/**

diff --git a/lib/private/AppFramework/Middleware/MiddlewareDispatcher.php b/lib/private/AppFramework/Middleware/MiddlewareDispatcher.php
@@ -63,7 +63,7 @@ public function __construct(){
 	 * @param Middleware $middleWare the middleware which will be added
 	 */
 	public function registerMiddleware(Middleware $middleWare){
-		array_push($this->middlewares, $middleWare);
+		$this->middlewares[] = $middleWare;
 	}
 
 

diff --git a/lib/private/Collaboration/Collaborators/GroupPlugin.php b/lib/private/Collaboration/Collaborators/GroupPlugin.php
@@ -102,13 +102,13 @@ public function search($search, $limit, $offset, ISearchResult $searchResult) {
 			// user id and if so, we add that to the exact match list
 			$group = $this->groupManager->get($search);
 			if ($group instanceof IGroup && (!$this->shareWithGroupOnly || in_array($group->getGID(), $userGroups))) {
-				array_push($result['exact'], [
+				$result['exact'][] = [
 					'label' => $group->getDisplayName(),
 					'value' => [
 						'shareType' => Share::SHARE_TYPE_GROUP,
 						'shareWith' => $group->getGID(),
 					],
-				]);
+				];
 			}
 		}
 

diff --git a/lib/private/Collaboration/Collaborators/UserPlugin.php b/lib/private/Collaboration/Collaborators/UserPlugin.php
@@ -128,13 +128,13 @@ public function search($search, $limit, $offset, ISearchResult $searchResult) {
 				}
 
 				if ($addUser) {
-					array_push($result['exact'], [
+					$result['exact'][] = [
 						'label' => $user->getDisplayName(),
 						'value' => [
 							'shareType' => Share::SHARE_TYPE_USER,
 							'shareWith' => $user->getUID(),
 						],
-					]);
+					];
 				}
 			}
 		}