Skip to content

Commit

Permalink
Merge pull request #22647 from nextcloud/fix/noid/depcreated-methods-…
Browse files Browse the repository at this point in the history
…settings

fix use of removed escapeHTML in settings.js
  • Loading branch information
rullzer authored Sep 8, 2020
2 parents ac5f291 + 43ea48c commit b4729ce
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions apps/settings/js/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ OC.Settings = _.extend(OC.Settings, {

_cachedGroups: null,

escapeHTML: function (text) {
return text.toString()
.split('&').join('&')
.split('<').join('&lt;')
.split('>').join('&gt;')
.split('"').join('&quot;')
.split('\'').join('&#039;');
},

/**
* Setup selection box for group selection.
*
Expand Down Expand Up @@ -75,10 +84,10 @@ OC.Settings = _.extend(OC.Settings, {
callback(selection);
},
formatResult: function(element) {
return escapeHTML(element.displayname);
return self.escapeHTML(element.displayname);
},
formatSelection: function(element) {
return escapeHTML(element.displayname);
return self.escapeHTML(element.displayname);
},
escapeMarkup: function(m) {
// prevent double markup escape
Expand Down

0 comments on commit b4729ce

Please sign in to comment.