Skip to content

Commit

Permalink
fixup! fix: Update children classes of Common to respect copy signature
Browse files Browse the repository at this point in the history
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
  • Loading branch information
come-nc committed Feb 22, 2024
1 parent d37436a commit c412f34
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
4 changes: 4 additions & 0 deletions apps/files_external/lib/Lib/Storage/AmazonS3.php
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,10 @@ public function touch($path, $mtime = null) {
return true;
}

/**
* @param string $source
* @param string $target
*/
public function copy($source, $target, bool $preserveMtime = false, ?bool $isFile = null): bool {
$source = $this->normalizePath($source);
$target = $this->normalizePath($target);
Expand Down
4 changes: 4 additions & 0 deletions apps/files_external/lib/Lib/Storage/SFTP.php
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,10 @@ public function writeStream(string $path, $stream, int $size = null): int {
}
}

/**
* @param string $source
* @param string $target
*/
public function copy($source, $target, bool $preserveMtime = false): bool {
if ($this->is_dir($source) || $this->is_dir($target)) {
return parent::copy($source, $target, $preserveMtime);
Expand Down
4 changes: 4 additions & 0 deletions apps/files_external/lib/Lib/Storage/Swift.php
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,10 @@ public function touch($path, $mtime = null) {
}
}

/**
* @param string $source
* @param string $target
*/
public function copy($source, $target, bool $preserveMtime = false): bool {
$source = $this->normalizePath($source);
$target = $this->normalizePath($target);
Expand Down

0 comments on commit c412f34

Please sign in to comment.